Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: docs(OWNERS): add alacuku (Aldo Lacuku) to approvers #214

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jun 17, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:

I am proposing myself as event-generator maintainer. As a GSoC mentor for the event-generator project (see issue #362), I need the ability to approve pull requests related to the project. Additionally, I would be happy to help maintain the project in the long run.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor

FedeDP commented Jun 17, 2024

Big +1 from me! Great to have you here :)
/hold until the majority is reached!

@leogr
Copy link
Member

leogr commented Jun 17, 2024

Big +1 from me as well!

/kind documentation

@poiana poiana added kind/documentation Improvements or additions to documentation and removed needs-kind labels Jun 17, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reached majority (100% of the votes in favor), so we can unblock this

/unhold

@poiana
Copy link

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: aa7ae559969d983ea71433da25f87973c95486dc

@leogr
Copy link
Member

leogr commented Jun 17, 2024

@alacuku welcome 🥳

@poiana poiana merged commit 7b41014 into falcosecurity:main Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants