feat(declarative): Implement ExecuteStep method for the container runner #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
reviewed
Aug 1, 2024
alacuku
reviewed
Aug 1, 2024
Updated the file structure in declarative package Added a helper function createTarReader which helps in copying files into the container Copied event-generator executable into the container Refactored setup and cleanup methods of the container runner Signed-off-by: GLVS Kiriti <[email protected]>
GLVSKiriti
force-pushed
the
SyscallSupportForContainerRunner
branch
from
7cb4684
to
db3fb9c
Compare
GLVSKiriti
changed the title
|
LGTM label has been added. Git tree hash: 21f9faa97d7a051be44152cf8d7f11fc91846efb
|
|
/approve |
LucaGuerra
approved these changes
Aug 5, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alacuku, GLVSKiriti, LucaGuerra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@alacuku @jasondellaluce