-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add attestation for falco #3216
Conversation
/milestone TBD (@LucaGuerra feel free to change the milestone!) |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
@cpanato @LucaGuerra |
i was in pto, returned today :) i will re-check this soon |
Stale issues rot after 30d of inactivity. Mark the issue as fresh with Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue with Mark the issue as fresh with Provide feedback via https://github.com/falcosecurity/community. |
@poiana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@cpanato should we reopen this? 🤔 |
/reopen |
@cpanato: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
06746e6
to
beee2c9
Compare
PTAL @leogr |
/remove-lifecycle rotten |
LGTM label has been added. Git tree hash: cba9a690339d8b1e37df296457a652f4ec7d1b9c
|
/milestone 0.40.0 |
Signed-off-by: cpanato <[email protected]>
beee2c9
to
1c3d7e0
Compare
PTAL @leogr @LucaGuerra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM label has been added. Git tree hash: 7d92b4298a1ac914aea6ec3e651bdad6f97dd9f8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind feature
/kind release
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
we need to hold this PR until the action supports the pushes to non ghcr.io registries
see Issue Push Docker Attestation: Support credential helpers actions/attest-build-provenance#80
/hold
/assign @LucaGuerra @leogr
Which issue(s) this PR fixes:
Fixes #2649
Special notes for your reviewer:
Does this PR introduce a user-facing change?: