Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attestation for falco #3216

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 27, 2024

What type of PR is this?
/kind feature
/kind release

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:

/hold

/assign @LucaGuerra @leogr

Which issue(s) this PR fixes:

Fixes #2649

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add attestation for falco

@FedeDP
Copy link
Contributor

FedeDP commented May 27, 2024

/milestone TBD

(@LucaGuerra feel free to change the milestone!)

@poiana poiana added this to the TBD milestone May 27, 2024
@poiana
Copy link
Contributor

poiana commented Aug 25, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Aug 27, 2024

@cpanato @LucaGuerra
any news on this?

@cpanato
Copy link
Member Author

cpanato commented Aug 27, 2024

i was in pto, returned today :) i will re-check this soon

@poiana
Copy link
Contributor

poiana commented Sep 26, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Oct 26, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this Oct 26, 2024
@poiana
Copy link
Contributor

poiana commented Oct 26, 2024

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@leogr
Copy link
Member

leogr commented Oct 28, 2024

@cpanato should we reopen this? 🤔

@cpanato
Copy link
Member Author

cpanato commented Oct 28, 2024

/reopen

@poiana poiana reopened this Oct 28, 2024
@poiana
Copy link
Contributor

poiana commented Oct 28, 2024

@cpanato: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato cpanato marked this pull request as ready for review October 29, 2024 11:48
@cpanato
Copy link
Member Author

cpanato commented Oct 29, 2024

PTAL @leogr

@leogr
Copy link
Member

leogr commented Oct 29, 2024

/remove-lifecycle rotten

leogr
leogr previously approved these changes Oct 29, 2024
@poiana poiana added the lgtm label Oct 29, 2024
@poiana
Copy link
Contributor

poiana commented Oct 29, 2024

LGTM label has been added.

Git tree hash: cba9a690339d8b1e37df296457a652f4ec7d1b9c

@FedeDP
Copy link
Contributor

FedeDP commented Oct 29, 2024

/milestone 0.40.0

@poiana poiana modified the milestones: TBD, 0.40.0 Oct 29, 2024
Signed-off-by: cpanato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Nov 27, 2024

PTAL @leogr @LucaGuerra

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana poiana added the lgtm label Dec 5, 2024
@poiana
Copy link
Contributor

poiana commented Dec 5, 2024

LGTM label has been added.

Git tree hash: 7d92b4298a1ac914aea6ec3e651bdad6f97dd9f8

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Dec 5, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Dec 5, 2024

/unhold

@poiana poiana merged commit 257ae9a into falcosecurity:master Dec 5, 2024
34 checks passed
@cpanato cpanato deleted the add-attestation branch December 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SLSA Provenance Attestation for Falco
5 participants