fix(metrics/prometheus): adopt best prometheus practices for rules counters and sha256 file metrics #3272
Conversation
userspace/falco/falco_metrics.cpp
Outdated
| @@ -174,7 +171,7 @@ std::string falco_metrics::to_text(const falco::app::state& state) | |||
| { | |||
| const stats_manager& rule_stats_manager = state.engine->get_rule_stats_manager(); | |||
| const indexed_vector<falco_rule>& rules = state.engine->get_rules(); | |||
| auto metric = libs_metrics_collector.new_metric("rules.matches_total", | |||
| auto metric = libs_metrics_collector.new_metric("rules_matches_total", | |||
There was a problem hiding this comment.
Item 3 #3271 (comment) (removing raw_name would be for the next release for sure alongside me moving the metric name sanitization to libs and I will also add a labels name sanitization method to libs).
There was a problem hiding this comment.
CC @Issif
@falcosecurity/falco-maintainers do we want a patch release for these minor fixes? This would allow us to create more powerful Grafana dashboards and accelerate the deprecation for the falco-exporter.
There was a problem hiding this comment.
I think a patch release with this + the centos7 EOL fix would be fine.
The only problem is the time constraint since we are nearing august and most maintainers will be off during that month!
There was a problem hiding this comment.
ACK, also re-pushed to actually not remove the sha256 🤦♀️
incertum
force-pushed
the
fix/rules-sha256-prom-metrics-naming
branch
2 times, most recently
from
42481da to
cba712d
Compare
|
Is this planned for 0.39? Right? 🤔 |
we are considering for the upcoming patch release, just so we can move forward with the new Grafana dashboards. |
|
cc @Issif FYI :) |
|
/milestone 0.38.2 |
…unters and sha256 file metrics Signed-off-by: Melissa Kilby <[email protected]>
incertum
force-pushed
the
fix/rules-sha256-prom-metrics-naming
branch
from
cba712d to
f4acc40
Compare
|
@LucaGuerra rebased. @Issif once merged could you re-test the metrics just to be sure it's all ok now? |
|
LGTM label has been added. Git tree hash: 457afdb7857d9f4c1774b489f8f3b24ffaa70ff1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Fixes #3271
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: