-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake,docker): avoid cpp-httplib requiring brotli. #3400
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.40.0 /cc @leogr @LucaGuerra Let's wait on the CI to build packages and check with |
This also reverts #3399 |
Thanks @FedeDP , as we discussed 🚀 |
/hold to run |
Using the tar.gz provided by the CI. vs On master:
/unhold |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Since we started using ubuntu runner as builder (instead of relying on centos:7, see #3307),
cpp-httplib
started usingbrotli
dep found in the system (that was not present on centos:7) since it defaultsHTTPLIB_USE_BROTLI_IF_AVAILABLE
toON
: https://github.com/yhirose/cpp-httplib/blob/master/CMakeLists.txt#L6Disable this behavior since we do not want the added dep.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: