Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(build): bump libs, reintroduce static build #3428

Merged
merged 9 commits into from
Dec 19, 2024
Merged

new(build): bump libs, reintroduce static build #3428

merged 9 commits into from
Dec 19, 2024

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Dec 13, 2024 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

This PR now does a few things:

  • Bump libs to latest master, fixing relevant issues
  • Fix the wasm build
  • Reintroduce the musl static build, it'll be back in Falco 0.40.0
  • Restructure test pipelines allowing asan logs to appear in the test results and removing some useless jobs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(build): reintroduce static build

@poiana poiana requested review from Kaizhe and leogr December 13, 2024 15:10
@poiana poiana added the size/M label Dec 13, 2024
@LucaGuerra LucaGuerra changed the title new(build): reintroduce static build wip: new(build): reintroduce static build Dec 13, 2024
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch 2 times, most recently from cb741be to cbff13d Compare December 16, 2024 17:08
@LucaGuerra
Copy link
Contributor Author

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Dec 17, 2024
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch from 0764e2a to 0d841d1 Compare December 17, 2024 14:53
@poiana poiana added size/L and removed size/M labels Dec 17, 2024
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch from 0d841d1 to 5c954aa Compare December 17, 2024 15:06
@LucaGuerra LucaGuerra changed the title wip: new(build): reintroduce static build new(build): reintroduce static build Dec 17, 2024
@LucaGuerra LucaGuerra changed the title new(build): reintroduce static build wip: new(build): reintroduce static build Dec 17, 2024
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch from 5c954aa to 869cbee Compare December 17, 2024 16:04
@LucaGuerra LucaGuerra changed the title wip: new(build): reintroduce static build wip: new(build): bump libs, reintroduce static build Dec 17, 2024
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch from 0f07504 to 9b99758 Compare December 17, 2024 17:11
@LucaGuerra LucaGuerra mentioned this pull request Dec 18, 2024
Merged
@LucaGuerra LucaGuerra force-pushed the new/reintroduce-static-build branch from 9b99758 to 75e0a49 Compare December 18, 2024 09:13
@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

LGTM label has been added.

Git tree hash: b6e4021118983d9f6f36fc391654debc19628f52

FedeDP
FedeDP reviewed Dec 18, 2024
View reviewed changes
.github/workflows/reusable_build_packages.yaml
@@ -139,10 +238,10 @@ jobs:
- name: Prepare project
run: |
cmake -B build -S . \
-DCMAKE_BUILD_TYPE=${{ inputs.build_type }} \
-DCMAKE_BUILD_TYPE=Release \
Copy link
Contributor

@FedeDP FedeDP Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to enforce jemalloc for musl build too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but I'm not a jemalloc expert. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that all of our release artifact should spot the same behavior, therefore i'd say yes!

@FedeDP
Copy link
Contributor

FedeDP commented Dec 18, 2024

/hold

Will give it a look later today :)

FedeDP
FedeDP reviewed Dec 18, 2024
View reviewed changes
.github/workflows/reusable_build_packages.yaml
runs-on: ubuntu-latest
container: alpine:3.17
steps:
# Always install deps before invoking checkout action, to properly perform a full clone.
- name: Install build dependencies
run: |
apk add g++ gcc cmake make git bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils bpftool clang
apk add g++ gcc cmake make git bash perl linux-headers autoconf automake m4 libtool elfutils-dev libelf-static patch binutils clang llvm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need elfutils-dev libelf-static deps here? Considering we are using a bundled build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are required to build bpftool.

FedeDP
FedeDP reviewed Dec 18, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@poiana poiana removed the lgtm label Dec 18, 2024
@poiana poiana requested a review from sgaist December 18, 2024 17:33
FedeDP
FedeDP approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@poiana poiana added the lgtm label Dec 19, 2024
@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

LGTM label has been added.

Git tree hash: f768fa37bea0285d6941e08aeee8614d43717c77

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Dec 19, 2024
Closed
Closed
Closed
@LucaGuerra
Copy link
Contributor Author

Thank you @sgaist @FedeDP @leogr for the reviews! Now we can get the Falco CI working again and release our static build in time for 0.40.0 🚀

@LucaGuerra
Copy link
Contributor Author

/unhold

@poiana poiana merged commit 02f3db9 into falcosecurity:master Dec 19, 2024
35 checks passed
@LucaGuerra LucaGuerra deleted the new/reintroduce-static-build branch December 19, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@leogr leogr leogr approved these changes

@sgaist sgaist sgaist approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@sgaist sgaist

@leogr leogr

@FedeDP FedeDP

Labels
approved area/build dco-signoff: yes kind/feature lgtm release-note size/L
Projects
Falco Roadmap
Status: Done
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaGuerra @poiana @FedeDP @sgaist @leogr