Fix asterisk link when src dir doesn't exist. #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-lawrence
force-pushed
the
sl/fix-loader-asterisk
branch
from
57b28d9 to
e46d7e1
Compare
poiana
added
dco-signoff: yes
release-note
and removed
dco-signoff: no
do-not-merge/release-note-label-needed
labels
LucaGuerra
reviewed
Dec 19, 2024
| @@ -50,7 +50,8 @@ echo "* Setting up /usr/src links from host" | |||
|
|
|||
| for i in "$HOST_ROOT/usr/src"/* | |||
| do | |||
| base=$(basename "$i") | |||
| [[ -e $i ]] || continue | |||
| base=$(basename "$i") | |||
|
/milestone 0.40.0 |
|
We just merged a fix for the failing CI, could you please rebase on top of master? Thank you 🙏 |
Signed-off-by: Shane Lawrence <[email protected]>
shane-lawrence
force-pushed
the
sl/fix-loader-asterisk
branch
from
e46d7e1 to
ab2c625
Compare
leogr
reviewed
Dec 19, 2024
Co-authored-by: Leonardo Grasso <[email protected]> Signed-off-by: Shane Lawrence <[email protected]>
leogr
approved these changes
Dec 19, 2024
|
LGTM label has been added. Git tree hash: dd4fae6315ff3425cc3132d00b95b5c8fd561fbc
|
|
Thanks! |
sgaist
approved these changes
Dec 19, 2024
LucaGuerra
approved these changes
Dec 19, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra, shane-lawrence The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it:
Check if path exists before creating link in driver-loader.
Which issue(s) this PR fixes:
Fixes #3433.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: