fix(mediaType): do not omit original media type if not a well known media type #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn media type While converting a media type to a human-friendly one, we omit the original one when handling unknown media types. Usually, we convert the media type when logging errors, so keeping the original media type when reporting an error is important. Signed-off-by: Aldo Lacuku <[email protected]>
loresuso
approved these changes
Dec 12, 2024
|
LGTM label has been added. Git tree hash: d7afcc3230a546349e61bd05f7188d029515c864
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While converting a media type to human friendly type, we ommit the original media type when handling not well known media types. Usually we convert the media type when logging errors, so it is important to keep the original media type when reporting an error.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area library
/area cli
What this PR does / why we need it:
fix(mediaType): do not omit the original media type if not a well-known media type
While converting a media type to a human-friendly one, we omit the original
one when handling unknown media types. Usually, we convert
the media type when logging errors, so keeping the
original media type when reporting an error is important.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: