chore: fix windows build

Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
falcosecurity · Dec 6, 2024 · 0b53bd7 · 0b53bd7
1 parent c5a3422
commit 0b53bd7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/userspace/libscap/engine/savefile/converter/CMakeLists.txt b/userspace/libscap/engine/savefile/converter/CMakeLists.txt
@@ -13,9 +13,9 @@
 # the License.
 #
 
-# Since we have circular dependencies between libscap and the savefile engine, make this library
-# always static (directly linked into libscap)
-add_library(scap_savefile_converter STATIC converter.cpp table.cpp)
+# Using `STATIC` is not enough on Windows builds, so we directly create object files that will be
+# included inside `scap_engine_savefile` library
+add_library(scap_savefile_converter OBJECT converter.cpp table.cpp)
 
 add_dependencies(scap_savefile_converter uthash)
 target_include_directories(