cleanup(metrics): remove duplicated new_metric method

Signed-off-by: Mauro Ezequiel Moltrasio <[email protected]>

userspace/libsinsp/metrics_collector.h

@@ -245,6 +245,9 @@ class libsinsp_metrics
 		}
 	}
 
+	/*!
+	\brief Method to create a new metrics_v2
+	*/
 	template <typename T>
 	static inline metrics_v2 new_metric(const char* name, uint32_t flags, metrics_v2_value_type type, metrics_v2_value_unit unit, metrics_v2_metric_type metric_type, T val)
 	{
@@ -333,22 +336,6 @@ class libs_metrics_collector
 	*/
 	std::vector<metrics_v2>& get_metrics();
 
-	/*!
-	\brief Method to create a new metrics_v2
-	*/
-	template <typename T>
-	metrics_v2 new_metric(const char* name, uint32_t flags, metrics_v2_value_type type, metrics_v2_value_unit unit, metrics_v2_metric_type metric_type, T val)
-	{
-		metrics_v2 metric;
-		strlcpy(metric.name, name, METRIC_NAME_MAX);
-		metric.flags = flags;
-		metric.type = type;
-		metric.unit = unit;
-		metric.metric_type = metric_type;
-		libsinsp_metrics::set_metric_value(metric, type, val);
-		return metric;
-	}
-
 private:
 	sinsp* m_inspector;
 	std::shared_ptr<sinsp_stats_v2> m_sinsp_stats_v2;