Skip to content

Commit

Permalink
fix(cmake): Make some dependency scopes private
Browse files Browse the repository at this point in the history
Make the base sinsp dependency scopes PRIVATE. This fixes compilation
here on macOS when BUILD_SHARED_LIBS=ON.

Signed-off-by: Gerald Combs <[email protected]>
  • Loading branch information
geraldcombs authored and poiana committed Sep 25, 2023
1 parent b61c297 commit 762c23b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions userspace/libsinsp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ set_sinsp_target_properties(sinsp)

target_link_libraries(sinsp
PUBLIC scap
INTERFACE
PRIVATE
"${CURL_LIBRARIES}"
"${JSONCPP_LIB}"
"${RE2_LIB}"
Expand Down Expand Up @@ -337,8 +337,8 @@ else()
endif() # NOT WIN32

if(APPLE)
target_link_libraries(sinsp INTERFACE "-framework CoreFoundation")
target_link_libraries(sinsp INTERFACE "-framework SystemConfiguration")
target_link_libraries(sinsp PRIVATE "-framework CoreFoundation")
target_link_libraries(sinsp PRIVATE "-framework SystemConfiguration")
set_target_properties(sinsp PROPERTIES LINK_FLAGS "-Wl,-F/Library/Frameworks")
endif()

Expand Down

0 comments on commit 762c23b

Please sign in to comment.