cleanup(tests): improve some names

Signed-off-by: Andrea Terzolo <[email protected]>
falcosecurity · Aug 26, 2024 · 7dc9dd3 · 7dc9dd3
1 parent 8e5d1a8
commit 7dc9dd3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/test/drivers/test_suites/syscall_enter_suite/connect_e.cpp b/test/drivers/test_suites/syscall_enter_suite/connect_e.cpp
@@ -2,7 +2,7 @@
 
 #if defined(__NR_connect)
 
-TEST(SyscallEnter, connectE_INET)
+TEST(SyscallEnter, connectE_INET_failure)
 {
 	auto evt_test = get_syscall_event_test(__NR_connect, ENTER_EVENT);
 
@@ -53,7 +53,7 @@ TEST(SyscallEnter, connectE_INET)
 	evt_test->assert_num_params_pushed(2);
 }
 
-TEST(SyscallEnter, connectE_INET6)
+TEST(SyscallEnter, connectE_INET6_failure)
 {
 	auto evt_test = get_syscall_event_test(__NR_connect, ENTER_EVENT);
 
@@ -104,7 +104,7 @@ TEST(SyscallEnter, connectE_INET6)
 	evt_test->assert_num_params_pushed(2);
 }
 
-TEST(SyscallEnter, connectE_UNIX)
+TEST(SyscallEnter, connectE_UNIX_failure)
 {
 	auto evt_test = get_syscall_event_test(__NR_connect, ENTER_EVENT);
 
@@ -164,7 +164,7 @@ TEST(SyscallEnter, connectE_UNIX)
 #define UNIX_LONG_PATH "/unix_socket/test/too_long/too_long/too_long/too_long/unix_socket/test/too_long/too_long/too_long/too_longgg*"
 #define EXPECTED_UNIX_LONG_PATH "/unix_socket/test/too_long/too_long/too_long/too_long/unix_socket/test/too_long/too_long/too_long/too_longgg"
 
-TEST(SyscallEnter, connectE_UNIX_max_path)
+TEST(SyscallEnter, connectE_UNIX_max_path_failure)
 {
 	auto evt_test = get_syscall_event_test(__NR_connect, ENTER_EVENT);
 
@@ -220,7 +220,7 @@ TEST(SyscallEnter, connectE_UNIX_max_path)
 	evt_test->assert_num_params_pushed(2);
 }
 
-TEST(SyscallEnter, connectE_null_sockaddr)
+TEST(SyscallEnter, connectE_null_sockaddr_failure)
 {
 	auto evt_test = get_syscall_event_test(__NR_connect, ENTER_EVENT);
 

diff --git a/test/drivers/test_suites/syscall_exit_suite/recvmsg_x.cpp b/test/drivers/test_suites/syscall_exit_suite/recvmsg_x.cpp
@@ -269,8 +269,8 @@ TEST(SyscallExit, recvmsgX_ipv4_tcp_NULL_sockaddr)
 	else
 	{
 		evt_test->assert_empty_param(4);
-		GTEST_SKIP() << "[RECVMSG_X]: we receive an empty tuple because the pointer to sockaddr is NULL, but "
-				"we should rely on kernel structs"
+		GTEST_SKIP() << "[RECVMSG_X]: we rely on the addrlen provided by the kernel but this seems to be always 0."
+			     << "we should rely on kernel structs"
 			     << std::endl;
 	}