Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(drivers): driver inconsistencies CHECK_RES #1388

Merged
merged 1 commit into from
Oct 6, 2023
Merged

cleanup(drivers): driver inconsistencies CHECK_RES #1388

merged 1 commit into from
Oct 6, 2023

Conversation

ecbadeaux
Copy link
Contributor

@ecbadeaux ecbadeaux commented Oct 5, 2023 •
edited by Andreagit97
Loading

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-bpf

/area driver-modern-bpf

Does this PR require a change in the driver versions?

No I do not think so.

What this PR does / why we need it:

Make driver code more consistent.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Tagging @dwindsor for visibility.

Does this PR introduce a user-facing change?:

NONE

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Please double check driver/API_VERSION file. See versioning.

/hold

@incertum incertum added this to the 0.14.0 milestone Oct 5, 2023
@incertum
Copy link
Contributor

incertum commented Oct 5, 2023

Ok now -- just for the future: We typically try to use commit conventions https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#commit-convention in a way similar to fix(drivers): ... and here we probably would have used cleanup(drivers): ....

Sometimes some spaces before the comments were removed, but it's not a big deal from my perspective.

incertum
incertum approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 5, 2023
@poiana
Copy link
Contributor

poiana commented Oct 5, 2023

LGTM label has been added.

Git tree hash: 08142b917e2c15672b7a41bd22f1ac0e2f119051

@poiana poiana added the approved label Oct 5, 2023
@ecbadeaux ecbadeaux changed the title Fix driver inconsistencies check res Fix driver inconsistencies CHECK_RES Oct 5, 2023
@ecbadeaux ecbadeaux changed the title Fix driver inconsistencies CHECK_RES cleanup(drivers): driver inconsistencies CHECK_RES Oct 5, 2023
@ecbadeaux
Copy link
Contributor Author

ecbadeaux commented Oct 5, 2023 •
edited
Loading

Ok now -- just for the future: We typically try to use commit conventions https://github.com/falcosecurity/.github/blob/main/CONTRIBUTING.md#commit-convention in a way similar to fix(drivers): ... and here we probably would have used cleanup(drivers): ....

Sometimes some spaces before the comments were removed, but it's not a big deal from my perspective.

@incertum Ok I squashed the commits and changed the commit message to match the standard, and the next commit was to add my signature.

@ecbadeaux
cleanup(drivers):driver inconsistencies CHECK_RES
b361ffc 
Signed-off-by: Everett Badeaux <[email protected]>

more check res additons

Signed-off-by: Everett Badeaux <[email protected]>

fix else statement

Signed-off-by: Everett Badeaux <[email protected]>

fix minimal errors

Signed-off-by: Everett Badeaux <[email protected]>

fix syntax errors

Signed-off-by: Everett Badeaux <[email protected]>

fix additional syntax errors

Signed-off-by: Everett Badeaux <[email protected]>

fix brace

Signed-off-by: Everett Badeaux <[email protected]>
Andreagit97
Andreagit97 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@poiana
Copy link
Contributor

poiana commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ecbadeaux, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

/unhold

@poiana poiana merged commit 2bea7ba into falcosecurity:master Oct 6, 2023
29 checks passed
@ecbadeaux ecbadeaux deleted the fix_driver_inconsistencies_CHECK_RES branch October 25, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@incertum incertum incertum approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@LucaGuerra LucaGuerra Awaiting requested review from LucaGuerra

Assignees

@incertum incertum

@Andreagit97 Andreagit97

Labels
approved area/driver-bpf area/driver-modern-bpf dco-signoff: yes kind/bug Something isn't working kind/cleanup lgtm release-note-none size/XXL
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ecbadeaux @incertum @poiana @Andreagit97