fix(driver): null pointer deref in kernels >=6.5 #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
do-not-merge/work-in-progress
kind/bug
|
Please double check driver/API_VERSION file. See versioning. /hold |
therealbobo
force-pushed
the
fix/ovl-6.5
branch
4 times, most recently
from
b0084fb to
b998515
Compare
therealbobo
changed the title
therealbobo
force-pushed
the
fix/ovl-6.5
branch
2 times, most recently
from
9962dbc to
392c00d
Compare
|
/milestone next-driver |
Andreagit97
reviewed
Oct 17, 2023
therealbobo
force-pushed
the
fix/ovl-6.5
branch
from
392c00d to
ede9f2b
Compare
therealbobo
force-pushed
the
fix/ovl-6.5
branch
from
ede9f2b to
897447e
Compare
FedeDP
reviewed
Oct 17, 2023
| { | ||
| return true; | ||
| } | ||
|
|
||
| // In kernels >=6.5 d_fsdata represents an ovl_entry_flag. | ||
| unsigned long flags = (unsigned long)BPF_CORE_READ(dentry, d_fsdata); |
There was a problem hiding this comment.
I'd put this in the else branch.
FedeDP
reviewed
Oct 17, 2023
Signed-off-by: Roberto Scolaro <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]> Co-authored-by: Andrea Terzolo <[email protected]>
therealbobo
force-pushed
the
fix/ovl-6.5
branch
5 times, most recently
from
4b6c606 to
9575190
Compare
Signed-off-by: Roberto Scolaro <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]> Co-authored-by: Andrea Terzolo <[email protected]>
therealbobo
force-pushed
the
fix/ovl-6.5
branch
from
9575190 to
8066b9d
Compare
|
LGTM label has been added. Git tree hash: 1c96a99b3fa1876dfca6e21ecb9b0bb3bffa36ec
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
Github PR mention works the other way around I thought it did: #1960 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
This fixes a null pointer deref in kernels >= 6.5.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: