update: collection of minor cleanups across the codebase #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such messages might end up flooding kernel logs. Silence them unless the "verbose" module parameter is enabled. Also, add information about the consumer. Signed-off-by: Jason Dellaluce <[email protected]> Co-authored-by: Gerlando Falauto <[email protected]>
… consistency Signed-off-by: Jason Dellaluce <[email protected]> Co-authred-by: Grzegorz Nosek <[email protected]>
Co-authored-by: Sahas Panda <[email protected]> Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]> Co-authored-by: Grzegorz Nosek <[email protected]>
…s and compilers An unusual syntax of the declaration of a constructor (`libsinps::events::set<T>()`) raises a warning when the compiler is gcc-11 and the build is done with C++20. Signed-off-by: Jason Dellaluce <[email protected]> Co-authored-by: Federico Aponte <[email protected]>
Co-authored-by: Roberto Scolaro <[email protected]> Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]> Co-authored-by: Matthew Knight <[email protected]>
|
/milestone 0.14.0 |
|
LGTM label has been added. Git tree hash: e6afe9f55e36acd1365236091dbfcd8d35c02f44
|
leogr
approved these changes
Oct 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
NO
What this PR does / why we need it:
This is a collection of minor cleanups across the whole codebase, mostly relate to missing cmake includes, nullptr checks (peculiarly important after the recent refactor from @Andreagit97), and resolution of compilation warnings.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: