Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(driver): create consistencies (syscall_arg_t) #1435

Merged
merged 1 commit into from
Oct 23, 2023
Merged

cleanup(driver): create consistencies (syscall_arg_t) #1435

merged 1 commit into from
Oct 23, 2023

Conversation

ecbadeaux
Copy link
Contributor

@ecbadeaux ecbadeaux commented Oct 22, 2023 •
edited
Loading

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-kmod

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Use more consistent types and standards across the dirver code base.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Tagging @dwindsor @incertum for visibility.

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Oct 22, 2023

@ecbadeaux: The label(s) area/driver cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Use more consistent types and standards across the dirver code base.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Tagging @dwindsor @incertum for visibility.

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/M label Oct 22, 2023
@github-actions
Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

incertum
incertum approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 23, 2023
@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

LGTM label has been added.

Git tree hash: de03b3da3dd1a74d23468c25d1f0e7d5a3a0bad8

Andreagit97
Andreagit97 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Andreagit97 Andreagit97 added this to the 0.14.0 milestone Oct 23, 2023
@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ecbadeaux, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

Thank you for this!

@Andreagit97
Copy link
Member

/unhold

@poiana poiana merged commit 0736581 into falcosecurity:master Oct 23, 2023
31 checks passed
This was referenced Oct 23, 2023
Merged
Merged
@ecbadeaux ecbadeaux deleted the fix-driver-inconsistencies-syscall_arg_t branch October 25, 2023 03:26
@FedeDP
Copy link
Contributor

FedeDP commented Oct 25, 2023

/milestone next-driver

@poiana poiana modified the milestones: 0.14.0, next-driver Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@incertum incertum incertum approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@incertum incertum

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/bug Something isn't working kind/cleanup lgtm release-note-none size/M
Projects
None yet
Milestone
7.0.0+driver
Development

Successfully merging this pull request may close these issues.
5 participants
@ecbadeaux @poiana @Andreagit97 @FedeDP @incertum