Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(bpf/fillers.h): create integer consistencies all types #1459

Closed
wants to merge 1 commit into from
Closed

cleanup(bpf/fillers.h): create integer consistencies all types #1459

wants to merge 1 commit into from

Conversation

ecbadeaux
Copy link
Contributor

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-bpf

Does this PR require a change in the driver versions?

No.

What this PR does / why we need it:

Make bpf code more consistent.

Which issue(s) this PR fixes:

part of #902
(partial fix other issues still remain in 902)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@github-actions
Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/milestone 0.14.0

@poiana poiana added this to the 0.14.0 milestone Oct 31, 2023
@poiana poiana added the lgtm label Oct 31, 2023
@poiana
Copy link
Contributor

poiana commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecbadeaux, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Oct 31, 2023

LGTM label has been added.

Git tree hash: 137c1ce7c0c0ee5250b02b6d96d16a3f17cc0db5

@ecbadeaux ecbadeaux closed this Nov 1, 2023
@ecbadeaux ecbadeaux deleted the bpf-fillers-consistencies branch November 1, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants