Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(driver): use only int_t types #1480

Merged

Conversation

ecbadeaux
Copy link
Contributor

@ecbadeaux ecbadeaux commented Nov 13, 2023

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area driver-bpf

Does this PR require a change in the driver versions?

I am not sure about this.

What this PR does / why we need it:

This resolves ALL inconsistencies using s/u type integers. The only instances that remain are either apart of vmlinux.h (which I believe we do not want to change) and instances inside a few structs. This should now allow us to close 902. The remaining should probably handled in a new issue if decided.

Which issue(s) this PR fixes:

part of #902

Special notes for your reviewer:
@incertum
This resolves ALL inconsistencies using s/u type integers. The only instances that remain are either apart of vmlinux.h (which I believe we do not want to change) and instances inside a few structs. This should now allow us to close 902. The remaining should probably be handled in a new issue if decided.

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 14, 2023

LGTM label has been added.

Git tree hash: 77f0f0956fb55d20a6f7977bf64e64b120d1c297

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecbadeaux, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4dd9c8a into falcosecurity:master Nov 14, 2023
29 checks passed
@Andreagit97 Andreagit97 changed the title cleanup(integer consistencies): use only int_t types cleanup(driver): use only int_t types Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants