-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update(driver): Introduce the BPF commands name #1545
Conversation
Please double check driver/API_VERSION file. See versioning. /hold |
Awesome! We will start reviewing soon. /milestone 0.15.0 |
c2eb682
to
ecab2da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohith-Raju since the goal is to use the string representation of the bpf cmd in Falco rules, could we add libsinsp filtercheck tests? Thank you!
2400bb0
to
f6db1df
Compare
@Rohith-Raju could we get a rebase, ty! @FedeDP kind bump to double-check if your change request was addressed, ty! |
Yes this is good to go for me ! |
Great, @Rohith-Raju we will approve once rebased, we have final agreement. |
Signed-off-by: rohith-raju <[email protected]>
Signed-off-by: RohithRaju <[email protected]>
Signed-off-by: RohithRaju <[email protected]>
Signed-off-by: RohithRaju <[email protected]>
This reverts commit 41208ce. Signed-off-by: RohithRaju <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 07941bd100f197c2744e33c89da9582ea4c120f8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, Rohith-Raju The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it: This PR introduces the BPF command names, so
evt.arg.cmd == BPF_PROG_LOAD
instead ofevt.arg.cmd == 5
can be usedsee: #1343
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: