-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use modern Lua functions in chisels #1616
chore: Use modern Lua functions in chisels #1616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/milestone 0.15.0
/approve
note for the second reviewer: not too knowledgeable about the chisels and our lua use, but just looking at the code changes totally LGTM
LGTM label has been added. Git tree hash: 83eaf67bd1e7110714440fbf448e12792830940e
|
@federico-sysdig few CI hiccups, will re-approve after fixing them all. |
@incertum Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b064be47a29feb490b8035151bd460c8108dc984
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
This needs to be rebased on master to fix CI :) |
Signed-off-by: Federico Aponte <[email protected]>
Signed-off-by: Federico Aponte <[email protected]>
Signed-off-by: Federico Aponte <[email protected]>
Signed-off-by: Federico Aponte <[email protected]>
186f10a
to
6ee42ca
Compare
@FedeDP Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 08ade2a68fbc0382d2a7bd11523743ea2e6224b3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, incertum, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @federico-sysdig This PR is blocked by this failing test 👇 Could you take a look please? 🙏 Otherwise, LGTM. |
@leogr I've looked and there is a test that's timing out. The test seems to be unrelated to the change and I don't recall it failing before rebasing (did it in order to be able to merge). Do we have experience of some tests failing erratically due to some other reason? |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No.
What this PR does / why we need it:
Replaces outdated functions of the library for embedding Lua with more modern ones. This will allow to upgrade the Lua library in the future. For instance Vcpkg, the Microsoft package manager, provides a more modern version of Lua that would need this change.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Some minor cleanup has been performed in the involved files.
Does this PR introduce a user-facing change?:
No.