-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(driver): properly use strscpy
.
#1632
Conversation
/milestone next-driver |
This also fixes build against v6.8-rc1: https://github.com/falcosecurity/libs/actions/runs/7622725910/job/20761330947 |
rc3 still fixed ;) |
Still good against linux 6.8-rc5: https://github.com/falcosecurity/libs/actions/runs/7622725910 |
Testing against rc6: https://github.com/falcosecurity/libs/actions/runs/8064072897 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
i think you need to rebase to remove the stale required jobs |
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
188de6c
to
70eee6b
Compare
You are right! Rebased! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
/version driver-API-version-patch
What this PR does / why we need it:
This PR adapts kmod code to use
strscpy
in place ofstrlcpy
in kernels wherestrscpy
is available (ie: since 4.3.0: torvalds/linux@30035e4).strscpy
is safer and has better results; moreover,strlcpy
is being sunsetted (https://lore.kernel.org/lkml/202401191311.B6AA79D@keescook/ in kernel 6.8 for the full removal, but the effort to drop it from all drivers did .start quite a while ago).See https://lwn.net/Articles/659214/ and
strscpy
code: https://elixir.bootlin.com/linux/latest/source/lib/string.c#L122Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: