Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(userspae/libsinsp): api methods for controlling automatic routines #1635

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind feature

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

The inspector does a series of automatic routines at every iteration of the next event processing function, however most of them can't be controlled or customized through API. This PR makes a step forward by providing API methods for controlling the garbage collection/purging routines of threads, user/groups, and containers. Methods and variables have been uniformed in naming.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

refactor(userspae/libsinsp): api methods for controlling automatic routines

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

LGTM label has been added.

Git tree hash: 414f71d68ef9ff2a1cdf4d368071495ee0d7e9ae

@FedeDP
Copy link
Contributor

FedeDP commented Jan 22, 2024

/milestone 0.15.0

@poiana poiana added this to the 0.15.0 milestone Jan 22, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/approve

@poiana poiana merged commit e2734c7 into master Jan 22, 2024
31 checks passed
@poiana
Copy link
Contributor

poiana commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana deleted the refactor/control-automatic-routines branch January 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants