cleanup: remove some include paths leftover + ci checks #1649
Conversation
poiana
added
kind/cleanup
release-note-none
dco-signoff: yes
kind/feature
therealbobo
force-pushed
the
cleanup-include-paths
branch
3 times, most recently
from
cb775bb to
3f0fca0
Compare
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
therealbobo
force-pushed
the
cleanup-include-paths
branch
from
3f0fca0 to
b24089d
Compare
|
/milestone 0.15.0 |
There was a problem hiding this comment.
Given that the other semgrep related workflow is called insecure-api, can't we call this one absolute-include-paths?
Or, we can have a single semgrep_checks workflow with multiple jobs in it (perhaps it is better this ways since they are related?)
There was a problem hiding this comment.
Agree on that. I also propose to organise the semgrep files in folders so we can avoid excluding single rules (as done in this PR). WDYT?
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
|
LGTM label has been added. Git tree hash: f076f38e89e0d14c42cfe120f2c5198930c8f479
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area build
/area CI
/area libscap
/area libpman
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This adds a semgrep rule to check if are being used relative paths in the includes. Further more it removes some leftovers.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: