Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/e2e): fixed event-generator cmdline arguments. #1664

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 31, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI
/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Fixes master CI: latest tagged event-generator added an explicit --all flag: https://github.com/falcosecurity/event-generator/releases/tag/v0.11.0 to enforce disabled-by-default rules.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 31, 2024

/milestone 0.15.0

@poiana poiana added this to the 0.15.0 milestone Jan 31, 2024
@poiana poiana added the size/XS label Jan 31, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3d757a2 into master Jan 31, 2024
34 checks passed
@poiana poiana deleted the fix/e2e_event_gen branch January 31, 2024 09:48
@FedeDP FedeDP mentioned this pull request Feb 9, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 9, 2024

/milestone 0.14.3

@poiana poiana modified the milestones: 0.15.0, 0.14.3 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants