Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): use new kernel-testing provided composite action. #1678

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Feb 8, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Moreover, bumped the framework to v0.3.0.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 8, 2024

/milestone 0.15.0
/hold

@poiana poiana added this to the 0.15.0 milestone Feb 8, 2024
@poiana poiana added the size/M label Feb 8, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 8, 2024

I will use this branch to start kernel-tests CI using the workflow provided here and check that everything is ok before unholding.

Andreagit97
Andreagit97 previously approved these changes Feb 8, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

jasondellaluce
jasondellaluce previously approved these changes Feb 8, 2024
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP FedeDP dismissed stale reviews from jasondellaluce and Andreagit97 via 1426079 February 8, 2024 09:45
@FedeDP FedeDP force-pushed the cleanup/use_new_kernel-testing branch 2 times, most recently from ab4c501 to cb24e51 Compare February 9, 2024 07:48
Moreover, bumped the framework to v0.3.0.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP FedeDP force-pushed the cleanup/use_new_kernel-testing branch from e7219d1 to 073640b Compare February 9, 2024 09:37
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 9, 2024

/unhold
We are ready to go :)

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 9, 2024

/unhold

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 9, 2024

Drivers CI Build / test-drivers-arm64 😇 (bundled_deps) (pull_request) Queued — Waiting to run this check...

Sigh

@poiana poiana merged commit 08ae1c0 into master Feb 9, 2024
34 checks passed
@poiana poiana deleted the cleanup/use_new_kernel-testing branch February 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants