Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(driver): collect dev and inode in all open-family syscalls #1755

Merged
merged 5 commits into from
Mar 20, 2024
Merged

new(driver): collect dev and inode in all open-family syscalls #1755

merged 5 commits into from
Mar 20, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Mar 18, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(driver): collect `dev` and `inode` in all open-family syscalls

@poiana poiana requested a review from hbrueckner March 18, 2024 15:23
@poiana poiana requested a review from jasondellaluce March 18, 2024 15:23
@poiana poiana added the size/L label Mar 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

Please double check driver/API_VERSION file. See versioning.

/hold

1 similar comment
@github-actions GitHub Actions
Copy link

Please double check driver/API_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor

FedeDP commented Mar 18, 2024

/milestone next-driver

@poiana poiana added this to the next-driver milestone Mar 18, 2024
@mrgian mrgian force-pushed the open-syscalls-inode branch from 3cff5a1 to b63b42e Compare March 18, 2024 21:02
@mrgian mrgian force-pushed the open-syscalls-inode branch from b63b42e to e0da8d5 Compare March 19, 2024 08:55
jasondellaluce
jasondellaluce reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

driver/SCHEMA_VERSION Outdated Show resolved Hide resolved
@mrgian
chore(driver): bump schema version
b4f48b6 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian mrgian force-pushed the open-syscalls-inode branch from e0da8d5 to b4f48b6 Compare March 19, 2024 11:14
FedeDP
FedeDP previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
/approve

@poiana poiana added the lgtm label Mar 20, 2024
@poiana
Copy link
Contributor

poiana commented Mar 20, 2024

LGTM label has been added.

Git tree hash: 66a5b0fc53caa05888fb1f4c1bac8bc8ac80ff76

@FedeDP
Copy link
Contributor

FedeDP commented Mar 20, 2024 •
edited
Loading

Uh just noticed, shouldn't we also update parsers: https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L2673 and https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L2707?

@FedeDP
Copy link
Contributor

FedeDP commented Mar 20, 2024

/hold

@poiana poiana removed the lgtm label Mar 20, 2024
@poiana poiana requested a review from FedeDP March 20, 2024 09:17
@mrgian
Copy link
Contributor Author

mrgian commented Mar 20, 2024

Uh just noticed, shouldn't we also update parsers: https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L2673 and https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L2707?

Forgot about that. I agree!
It should be fixed now.

FedeDP
FedeDP approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Mar 20, 2024
@poiana
Copy link
Contributor

poiana commented Mar 20, 2024

LGTM label has been added.

Git tree hash: 70f0e9f6a0495e171ecaa17d0ac0fb51af8d5690

@FedeDP
Copy link
Contributor

FedeDP commented Mar 20, 2024

/unhold

@poiana
Copy link
Contributor

poiana commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1ade13c into falcosecurity:master Mar 20, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved area/driver-bpf area/driver-kmod area/driver-modern-bpf area/libsinsp area/tests dco-signoff: yes lgtm release-note size/L
Projects
None yet
Milestone
7.1.0+driver
Development

Successfully merging this pull request may close these issues.
4 participants
@mrgian @FedeDP @poiana @jasondellaluce