-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): avoid sending a NULL tuple in recvfrom
syscall
#1767
Conversation
Please double check driver/API_VERSION file. See versioning. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check driver/API_VERSION file. See versioning.
/hold
This is a false positive for the API_VERSION. However, it seems to meet a specific case for the SCHEMA_VERSION 👇
When to increment
major version: increment when the schema becomes incompatible with previous userspace versions
minor version: increment when new features are added but existing features remain compatible (e.g. new event fields or new events)
patch version: increment when code changes don't break compatibility 👉 (e.g. bug fixes in filler code) 👈
So, could you bump the patch number of the schema version, please? 🙏
Bumped! |
/milestone next-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Common behavior is best behavior :)
/approve
LGTM label has been added. Git tree hash: a921443494431b0c7b9f851c6c23f41c18d67f49
|
65f088b
to
3fea0c1
Compare
Signed-off-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]>
3fea0c1
to
e3afeb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
LGTM label has been added. Git tree hash: b10ed3916654a6e981e068f02b588a45b8afd993
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
The kernel module and the old bpf probe send a NULL tuple to userspace when
recvfrom
is called with a nullsockaddr
pointer.This PR fixes this behavior by getting the tuple info from the socket file descriptor itself.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: