Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinsp_cgroup goodies #1861

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

deepskyblue86
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area libscap
/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Make some scap_cgroup information available from sinsp_cgroup.

  • update(sinsp_cgroup): expose in_cgroupns
  • update(sinsp_cgroup): expose self_v2
  • update(sinsp_cgroup): add with_self_cg to the ctors

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 10, 2024

LGTM label has been added.

Git tree hash: 90773bcb39710c8d3ad38f0298f1e01dce67551f

@FedeDP
Copy link
Contributor

FedeDP commented May 10, 2024

/milestone 0.17.0

@poiana poiana added this to the 0.17.0 milestone May 10, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented May 10, 2024

/hold

@deepskyblue86
Copy link
Member Author

@FedeDP @incertum ☺️ ☺️

@FedeDP
Copy link
Contributor

FedeDP commented May 10, 2024

/unhold

@poiana poiana merged commit ef6aea3 into falcosecurity:master May 10, 2024
39 of 40 checks passed
@deepskyblue86 deepskyblue86 deleted the sinsp_cgroup-goodies branch May 10, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants