-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(userspace/libsinsp): support lxc 4.0 cgroup layout. #1879
Conversation
Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.18.0 |
I was able to test it by spawning an lxc container and checking the
Most fields are empty because we actually only load the container id (that was already the case before my fix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I propose to backport this to the 0.17.1 tag, since it is an handy fix. /milestone 0.17.1 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
LXC 4.0 uses a new cgroup prefix/layout: https://linuxcontainers.org/lxc/news/2020_03_25_13_03.html
This PR adds support for it.
Which issue(s) this PR fixes:
Fixes #
See falcosecurity/falco#3213
Special notes for your reviewer:
Does this PR introduce a user-facing change?: