Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmake): workaround CI issue for windows. #1902

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 11, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This PR workarounds an issue with the github windows runner: actions/runner-images#10004

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 11, 2024

/milestone 0.17.2

@poiana poiana added the size/XS label Jun 11, 2024
@poiana poiana added this to the 0.17.2 milestone Jun 11, 2024
@poiana poiana requested review from Andreagit97 and hbrueckner June 11, 2024 15:36
@FedeDP FedeDP changed the title chore(ci): workaround CI issue for windows. wip: chore(ci): workaround CI issue for windows. Jun 11, 2024
@FedeDP FedeDP force-pushed the chore/workaround_win_issue branch from 5a23738 to 5e2a085 Compare June 12, 2024 06:55
@FedeDP FedeDP changed the title wip: chore(ci): workaround CI issue for windows. chore(cmake): workaround CI issue for windows. Jun 12, 2024
Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link
Contributor

poiana commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5c5edf2 into master Jun 12, 2024
40 checks passed
@poiana poiana deleted the chore/workaround_win_issue branch June 12, 2024 08:02
@FedeDP FedeDP mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants