-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cri): cri-dockerd
support
#1907
Conversation
cri-dockerd
support
cri-dockerd
supportcri-dockerd
support
/milestone 0.18.0 |
Signed-off-by: Melissa Kilby <[email protected]>
3bbfb50
to
59d83b0
Compare
cri-dockerd
supportcri-dockerd
support
I have the Falco PR up as well. This is ready for review, thanks. |
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
@incertum should we also add cri-dockerd in rules? |
Let's check, it may be just like regular docker (haven't checked the proc lineage) . I believe cri-dockerd is just a wrapper socket on top. |
@falcosecurity/libs-maintainers any news on this PR or objections? Ty |
I haven't tested it, anyway no concerns from me. |
LGTM label has been added. Git tree hash: b81dad75b8b8c6bf4086abe8dbed6c4f63577bd9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Support
cri-dockerd
container runtime. Fixes falcosecurity/falco#3243.To avoid looking up docker containers in this scenario from both the cri wrapper socket and the original docker socket configure the client like this: falcosecurity/falco#3243 (comment).
Falco PR falcosecurity/falco#3266.
Which issue(s) this PR fixes:
falcosecurity/falco#3243
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: