cleanup(tests): move filter compilation functions to sinsp_with_test_input #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.18.0 |
LucaGuerra
changed the title
…input Signed-off-by: Luca Guerra <[email protected]>
LucaGuerra
force-pushed
the
cleanup/test-cleanup-compilation
branch
from
ed73c09 to
a4791fb
Compare
LucaGuerra
changed the title
|
LGTM label has been added. Git tree hash: ed6cd07bbf9b94c1c9a2b55c6e8f4d56297291ee
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Recently I added
eval_filter()to add an urgent regression test. This one is not urgent but since we hadtwothree different ways of evaluating a filter in tests I wanted to consolidate it in one single way.The
sinsp_with_test_inputway is preferred IMO because it uses a real inspector and some filterchecks require an inspector to be present and initialized in order to work.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: