Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): add tests for event result #1913

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area tests

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

While writing other tests I noticed how evt.res and related fields work, so I added coverage for those as well.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

incertum
incertum previously approved these changes Jun 14, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 14, 2024

LGTM label has been added.

Git tree hash: d9f888cc3a09f27f301e60633fa0858cce760b07

FedeDP
FedeDP previously approved these changes Jun 17, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP
Copy link
Contributor

FedeDP commented Jun 17, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jun 17, 2024
@LucaGuerra LucaGuerra dismissed stale reviews from FedeDP and incertum via 6b1863d June 17, 2024 09:44
@poiana poiana removed the lgtm label Jun 17, 2024
@poiana poiana requested review from FedeDP and incertum June 17, 2024 09:44
@LucaGuerra LucaGuerra force-pushed the new/test-event-result branch from 6b1863d to 38046d7 Compare June 17, 2024 09:46
FedeDP
FedeDP previously approved these changes Jun 17, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 17, 2024
@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: 242d0226e991773fc298d0ea5f10195ba064c247

Andreagit97
Andreagit97 previously approved these changes Jun 17, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 17, 2024
@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: ba1241d3fc37e9424585672f896245d7d00d2de6

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 570b86c into falcosecurity:master Jun 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants