Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: introduce proc.{stdin,stdout,stderr}.{name,type} fields #1916

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Jun 17, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Please check the motivations for this PR in #1894
If we all agree on this direction, my call is to start a deprecation process for fd.types because:

  • it can't be used with any syscall. Even if we work to achieve this, it wouldn't be correct as per documentation says, the fd category should be used only against event types that handle/create file descriptors
  • the fd.types used as output field is useless, given that it returns an unordered list of types
  • we only really care about stdin, stdout, and stderr, and having them explicitly expressed helps readability (instead of using 0,1,2 as arguments of the field).
  • also, exposing the name part allow us for better detection and actionability (e.g in case of rev shell we see the connection tuple, in case of shell redirection to file the file itself and so on)

Curious to get your feedback!
(example condition for rev shells: evt.type=execve and evt.dir=< and proc.stdin.type=ipv4 and proc.name contains bash)

Which issue(s) this PR fixes:

Fixes #1894

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new: introduce proc.{stdin,stdout,stderr}.{name,type} fields

@loresuso loresuso changed the title new: introduce proc.fd.{stdin,stdout,stderr}.{name,type} fields new: introduce proc.{stdin,stdout,stderr}.{name,type} fields Jun 18, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 18, 2024

LGTM label has been added.

Git tree hash: 266f92b058a3a2b27b7a4dc6b23bcce44509c895

@Andreagit97 Andreagit97 added this to the 0.18.0 milestone Jun 18, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d1d021f into falcosecurity:master Jun 18, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend fd.types to be used with any system call
4 participants