Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sinsp): invalid threads shoudln't be in a pid namespace #1923

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(sinsp): invalid threads shoudln't be in a pid namespace #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion userspace/libsinsp/threadinfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ class SINSP_PUBLIC sinsp_threadinfo : public libsinsp::state::table_entry
*/
inline bool is_in_pid_namespace() const
{
return (m_flags & PPM_CL_CHILD_IN_PIDNS || m_tid != m_vtid);
// m_tid should be always valid because we read it from the scap event header
return (m_flags & PPM_CL_CHILD_IN_PIDNS || (m_tid != m_vtid && m_vtid >= 0));
}

/*!
Expand Down
Loading