new(ci): added perf CI job around scap file read. #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <[email protected]>
poiana
added
release-note
kind/feature
|
/milestone 0.18.0 |
FedeDP
commented
Jun 20, 2024
| @@ -30,52 +30,78 @@ jobs: | |||
| mkdir -p build | |||
| cd build && cmake -DUSE_BUNDLED_DEPS=False ../ | |||
| make unit-test-libsinsp -j4 | |||
| make sinsp-example -j4 | |||
There was a problem hiding this comment.
Build sinsp-example too
FedeDP
commented
Jun 20, 2024
| shell: bash | ||
| run: | | ||
| cd build | ||
| wget https://download.falco.org/fixtures/trace-files/traces-positive.zip |
There was a problem hiding this comment.
Download traces-positive trace files from download.falco.org
FedeDP
commented
Jun 20, 2024
| if-no-files-found: error | ||
|
|
||
| - name: Download latest master report | ||
| if: github.event_name == 'pull_request' | ||
| uses: dawidd6/action-download-artifact@v6 | ||
| with: | ||
| workflow: ci.yml | ||
| workflow: perf.yml |
There was a problem hiding this comment.
Same fix made in last commit of #1910
FedeDP
commented
Jun 20, 2024
| if: github.event_name == 'pull_request' | ||
| run: | | ||
| sudo perf diff perf.data build/perf.data -d unit-test-libsinsp -b -o 0 --percentage relative -q &> perf_diff.txt | ||
| sudo perf diff perf_tests.data build/perf_tests.data -d unit-test-libsinsp -b -o 1 --percentage relative -q &> perf_tests_diff.txt |
There was a problem hiding this comment.
Switched to -o 1 ordering that means to order the diff by absolute difference, descendent
Perf diff from master - unit tests |
leogr
approved these changes
Jun 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Expands #1918 adding a perf CI job to test scap file read from sinsp-example.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The CI will break because master perf_report has no scap file related perf data.
Does this PR introduce a user-facing change?: