Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use semver tag version for kernel-testing action. #1970

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 22, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Images are not pushed under the hash name.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Images are not pushed under the hash name.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 22, 2024

/milestone 0.18.0

/cc @LucaGuerra

@poiana poiana requested a review from LucaGuerra July 22, 2024 09:17
@poiana poiana added this to the 0.18.0 milestone Jul 22, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 22, 2024

Fixes master kernel-testing CI.

@poiana poiana added the size/XS label Jul 22, 2024
Copy link

Perf diff from master - unit tests

     4.91%     +1.06%  [.] sinsp_evt::get_type
     1.74%     -0.74%  [.] libsinsp::sinsp_suppress::process_event
     3.46%     +0.71%  [.] gzfile_read
     0.16%     +0.57%  [.] sinsp_evt::is_filtered_out
    10.23%     +0.52%  [.] sinsp_parser::reset
     1.47%     -0.50%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.64%     -0.44%  [.] copy_and_sanitize_path
     7.23%     +0.40%  [.] sinsp::next
     1.12%     -0.37%  [.] sinsp_parser::event_cleanup
     0.65%     -0.34%  [.] scap_file_test_helpers::capture_search_evt_by_num

Perf diff from master - scap file

    12.87%     -6.19%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.32%     +4.88%  [.] sinsp_evt_formatter::tostring_withformat
     9.60%     -4.21%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     6.85%     -2.47%  [.] sinsp_filter_check::rawval_to_string
    10.92%     +1.92%  [.] sinsp::next
    14.32%     +1.56%  [.] sinsp_filter_check::extract_nocache
     3.32%     +1.38%  [.] sinsp_thread_manager::find_thread
     3.31%     +1.10%  [.] sinsp_threadinfo::~sinsp_threadinfo
     9.96%     -0.92%  [.] sinsp_filter_check::tostring
     4.14%     +0.91%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

total runtime: -0.09s.
calls to allocation functions: 321 (-3732/s)
temporary memory allocations: 333 (-3872/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.006000s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.95%. Comparing base (4e3aebe) to head (286002d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   50.95%   50.95%           
=======================================
  Files         310      310           
  Lines       39540    39540           
  Branches    17208    17149   -59     
=======================================
+ Hits        20146    20147    +1     
+ Misses      14354    14345    -9     
- Partials     5040     5048    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 31d1adf into master Jul 22, 2024
44 of 46 checks passed
@poiana poiana deleted the chore/use_semver_ver_kernel-testing branch July 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants