Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): fix Falco compilation error on libsinsp_metrics::set_metric_value #1971

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions userspace/libsinsp/metrics_collector.h
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class output_rule_metrics_converter : public metrics_converter

class libsinsp_metrics
{
protected:
public:
template <typename T>
static void set_metric_value(metrics_v2& metric, metrics_v2_value_type type, T val)
{
Expand Down Expand Up @@ -245,7 +245,6 @@ class libsinsp_metrics
}
}

public:
template <typename T>
static inline metrics_v2 new_metric(const char* name, uint32_t flags, metrics_v2_value_type type, metrics_v2_value_unit unit, metrics_v2_metric_type metric_type, T val)
{
Expand Down Expand Up @@ -346,7 +345,7 @@ class libs_metrics_collector
metric.type = type;
metric.unit = unit;
metric.metric_type = metric_type;
set_metric_value(metric, type, val);
libsinsp_metrics::set_metric_value(metric, type, val);
return metric;
}

Expand Down
Loading