Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): Use the correct zlib debug library name on Windows #1979

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

geraldcombs
Copy link
Contributor

The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib.

Signed-off-by: Gerald Combs <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, geraldcombs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jul 31, 2024

LGTM label has been added.

Git tree hash: ce725ef43adf0f897aa137860947f73f5c35bc21

@FedeDP
Copy link
Contributor

FedeDP commented Jul 31, 2024

/cc @LucaGuerra
/milestone 0.17.3

@poiana poiana requested a review from LucaGuerra July 31, 2024 07:16
@poiana poiana added this to the 0.17.3 milestone Jul 31, 2024
Copy link

Perf diff from master - unit tests

     9.11%     +2.53%  [.] sinsp_parser::reset
     5.38%     -1.69%  [.] sinsp_evt::get_type
     8.09%     -1.12%  [.] sinsp::next
     1.67%     -0.86%  [.] sinsp_evt::get_ts
     2.87%     -0.63%  [.] sinsp_thread_manager::find_thread
     0.40%     +0.59%  [.] sinsp_evt::is_filtered_out
     2.35%     -0.58%  [.] scap_event_decode_params
     0.46%     +0.53%  [.] sinsp_cgroup::lookup_cgroups
     0.57%     +0.46%  [.] sinsp_utils::find_longest_matching_evt_param
     0.91%     +0.43%  [.] sinsp::fetch_next_event

Perf diff from master - scap file

     3.39%     +6.94%  [.] sinsp_filter_check::tostring
     3.61%     +4.63%  [.] main
    18.06%     -2.96%  [.] sinsp_evt_formatter::tostring_withformat
     3.51%     +2.50%  [.] sinsp_filter_check_container::extract_single
     7.20%     -1.93%  [.] sinsp_threadinfo::~sinsp_threadinfo
     7.21%     -1.66%  [.] sinsp_filter_check::get_transformed_field_info
    10.33%     -0.78%  [.] 0x00000000000a76b4
    10.77%     -0.73%  [.] next
     3.61%     +0.35%  [.] sinsp_evt::get_param_as_str
     3.60%     +0.26%  [.] sinsp_filter_check::extract

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -30B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (64fe187) to head (2dadcdd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1979   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files         310      310           
  Lines       39612    39612           
  Branches    17333    17417   +84     
=======================================
+ Hits        20197    20198    +1     
- Misses      14340    14347    +7     
+ Partials     5075     5067    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit f960a90 into falcosecurity:master Jul 31, 2024
45 of 46 checks passed
@FedeDP FedeDP mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants