-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(cmake): Use the correct zlib debug library name on Windows #1979
Conversation
The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib. Signed-off-by: Gerald Combs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, geraldcombs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: ce725ef43adf0f897aa137860947f73f5c35bc21
|
/cc @LucaGuerra |
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
=======================================
Coverage 50.98% 50.98%
=======================================
Files 310 310
Lines 39612 39612
Branches 17333 17417 +84
=======================================
+ Hits 20197 20198 +1
- Misses 14340 14347 +7
+ Partials 5075 5067 -8 ☔ View full report in Codecov by Sentry. |
The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: