Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: release 0.17.x #1988

Merged
merged 1 commit into from
Aug 1, 2024
Merged

sync: release 0.17.x #1988

merged 1 commit into from
Aug 1, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 1, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks #1886 from master.
This also fixes windows CI going crazy on release branch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Aug 1, 2024

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 1, 2024

Closing and reopening to trigger correct CI :D
/close

@poiana
Copy link
Contributor

poiana commented Aug 1, 2024

@FedeDP: Closed this PR.

In response to this:

Closing and reopening to trigger correct CI :D
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana closed this Aug 1, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 1, 2024

/reopen

@poiana poiana reopened this Aug 1, 2024
@poiana
Copy link
Contributor

poiana commented Aug 1, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 1, 2024

/milestone 0.17.3

@poiana poiana added this to the 0.17.3 milestone Aug 1, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 1, 2024

/unhold

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🥳

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8a71c89 into release/0.17.x Aug 1, 2024
61 of 63 checks passed
@poiana poiana deleted the sync/release_0.17.x branch August 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants