-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(sinsp): Fix infer_defaults_to_first_non_loopback TC #1989
Conversation
Modifying parse_ipv4_addr function to ensure that the IP address is correctly parsed and combined into a 32-bit integer of the correct byte order for Big-Endian systems. Modifying the convert_to_string function to extract the bytes in the correct order for Big-Endian systems. Signed-off-by: Soham Munshi <[email protected]>
Welcome @SohamM-Ibm! It looks like this is your first PR to falcosecurity/libs 🎉 |
The PR resolves the Test case failure observed on s390x system for
|
@Andreagit97 May you please review. |
/milestone 0.18.0 |
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1989 +/- ##
========================================
Coverage 50.98% 50.98%
========================================
Files 310 310
Lines 39612 39612
Branches 17455 17626 +171
========================================
Hits 20197 20197
- Misses 14338 14354 +16
+ Partials 5077 5061 -16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
/approve
LGTM label has been added. Git tree hash: 0af7d27660890d95e3f8b1a8041cbf38f969edf6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, SohamM-Ibm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
We need to ensure the same byte order for all architectures, so added the Byte order modifiers.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: