Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): use codecov flag for libsinsp #1995

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Trying to get codecov to behave even if not all tests are computing coverage at this point.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Aug 7, 2024

Perf diff from master - unit tests

     8.03%     -0.80%  [.] sinsp::next
     1.17%     +0.67%  [.] sinsp::fetch_next_event
     1.99%     -0.65%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.87%     +0.61%  [.] sinsp_evt::get_type
     5.25%     +0.50%  [.] next
     1.84%     -0.50%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.85%     -0.49%  [.] gzfile_read
     4.57%     -0.48%  [.] sinsp_evt::load_params
     0.73%     -0.47%  [.] libsinsp::runc::match_container_id
     3.06%     +0.39%  [.] sinsp_thread_manager::find_thread

Perf diff from master - scap file

    11.17%     +9.41%  [.] sinsp_evt_formatter::tostring_withformat
     3.48%     +5.24%  [.] sinsp_split[abi:cxx11]
     3.74%     +3.23%  [.] sinsp_parser::reset
    11.31%     +3.09%  [.] sinsp_filter_check::rawval_to_string
     3.78%     +3.04%  [.] sinsp_thread_manager::get_thread_ref
    11.64%     -3.01%  [.] sinsp_filter_check::tostring
    14.82%     -2.00%  [.] sinsp_filter_check_event::extract_single
    10.88%     +1.85%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     7.21%     -1.20%  [.] libsinsp::runc::match_container_id
     7.39%     -0.99%  [.] sinsp::next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (ae812ee) to head (dfdfa6c).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1995       +/-   ##
===========================================
+ Coverage   51.21%   74.08%   +22.87%     
===========================================
  Files         311      253       -58     
  Lines       39671    30766     -8905     
  Branches    17929     5418    -12511     
===========================================
+ Hits        20317    22793     +2476     
+ Misses      14262     7963     -6299     
+ Partials     5092       10     -5082     
Flag Coverage Δ
libsinsp 74.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra LucaGuerra force-pushed the update/codecov-flag-libsinsp branch from 5d43c9b to dfdfa6c Compare August 7, 2024 08:59
Copy link

github-actions bot commented Aug 7, 2024

Perf diff from master - unit tests

     4.52%     -1.28%  [.] sinsp_evt::load_params
     7.94%     -1.23%  [.] sinsp::next
     2.64%     +1.01%  [.] sinsp_thread_manager::get_thread_ref
     5.81%     -0.87%  [.] sinsp_evt::get_type
    10.81%     -0.58%  [.] sinsp_parser::reset
     0.78%     +0.53%  [.] sinsp_parser::event_cleanup
     3.80%     +0.49%  [.] gzfile_read
     1.97%     -0.48%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.49%     -0.43%  [.] libsinsp::events::is_unknown_event
     0.72%     -0.42%  [.] libsinsp::runc::match_container_id

Perf diff from master - scap file

     8.04%     +5.46%  [.] sinsp_evt_formatter::tostring_withformat
    16.72%     -5.36%  [.] sinsp_filter_check::extract_nocache
    10.67%     -3.24%  [.] sinsp_filter_check_event::extract_single
     7.83%     -3.22%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     2.71%     +1.75%  [.] sinsp_filter_check_thread::extract_single
     2.72%     +1.73%  [.] sinsp_thread_manager::get_thread_ref
     5.19%     -1.70%  [.] libsinsp::runc::match_container_id
     8.14%     -1.68%  [.] sinsp_filter_check::rawval_to_string
     5.32%     -1.65%  [.] sinsp::next
     2.68%     +1.64%  [.] 0x00000000000a8700

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@LucaGuerra LucaGuerra changed the title wip: update(ci): use codecov flag for libsinsp update(ci): use codecov flag for libsinsp Aug 7, 2024
@Andreagit97 Andreagit97 added this to the 0.18.0 milestone Aug 7, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 7, 2024

LGTM label has been added.

Git tree hash: 5b9a1a14d985af398b012a52a41ae6a34cef6f7f

@poiana
Copy link
Contributor

poiana commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2c2e9b0 into falcosecurity:master Aug 7, 2024
46 checks passed
@LucaGuerra LucaGuerra deleted the update/codecov-flag-libsinsp branch August 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants