Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove spurious strategy statement #1999

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Aug 8, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Some linters/IDEs (e.g. Visual Studio 2022) complain about this statement and mark it as error, remove this. The issue is that it's missing the "matrix" (which we don't use here so it's ok)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra
Copy link
Contributor Author

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Perf diff from master - unit tests

    10.73%     +1.93%  [.] sinsp_parser::reset
     4.77%     +1.93%  [.] next
     7.10%     -1.54%  [.] sinsp::next
     5.61%     -1.45%  [.] sinsp_parser::process_event
     6.60%     -1.22%  [.] sinsp_evt::get_type
     2.11%     +1.18%  [.] sinsp_thread_manager::get_thread_ref
     4.60%     -1.00%  [.] gzfile_read
     0.98%     +0.59%  [.] scap_event_encode_params_v
     0.34%     +0.57%  [.] sinsp_evt::get_param
     1.05%     -0.53%  [.] scap_event_has_large_payload

Perf diff from master - scap file

     7.06%     +7.87%  [.] sinsp_filter_check::extract_nocache
    17.63%     -3.76%  [.] sinsp_evt_formatter::tostring_withformat
     8.97%     -3.11%  [.] sinsp::fetch_next_event
     7.32%     -2.41%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
    10.05%     -2.00%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     6.52%     -1.84%  [.] sinsp_split[abi:cxx11]
     3.52%     +1.73%  [.] sinsp_thread_manager::find_thread
     3.45%     +1.68%  [.] sinsp_parser::process_event
     3.52%     +1.67%  [.] next
     4.58%     -0.55%  [.] sinsp_filter_check_thread::extract_single

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (a118b0f) to head (169b9f6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
- Coverage   74.08%   74.08%   -0.01%     
==========================================
  Files         253      253              
  Lines       30766    30766              
  Branches     5399     5405       +6     
==========================================
- Hits        22794    22792       -2     
- Misses       7946     7961      +15     
+ Partials       26       13      -13     
Flag Coverage Δ
libsinsp 74.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 8, 2024

LGTM label has been added.

Git tree hash: e84165dfa526bc03ffa52483324194b268d58c9d

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5b40fe6 into falcosecurity:master Aug 8, 2024
45 of 46 checks passed
@LucaGuerra LucaGuerra deleted the fix/ci-strategy-macos branch August 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants