Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): add a new test for execveat with AT_EMPTY_PATH #2002

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Aug 9, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area tests

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR adds a new test for execveat with AT_EMPTY_PATH flag

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Aug 9, 2024

Perf diff from master - unit tests

     2.87%     -1.22%  [.] scap_event_decode_params
     2.76%     +1.14%  [.] sinsp_thread_manager::get_thread_ref
     6.31%     -1.14%  [.] next
    10.60%     -0.74%  [.] sinsp_parser::reset
     0.22%     +0.72%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     2.88%     +0.67%  [.] sinsp_thread_manager::find_thread
     0.66%     +0.60%  [.] sinsp_filter_check::parse_field_name
     0.62%     -0.47%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_insert_unique_node
     0.56%     -0.47%  [.] sinsp_thread_manager::new_fdinfo
     1.58%     +0.44%  [.] libsinsp::sinsp_suppress::process_event

Perf diff from master - scap file

     4.67%     +7.07%  [.] gzfile_read
    20.17%     -6.60%  [.] sinsp_filter_check_event::extract_single
    15.34%     -4.40%  [.] sinsp_filter_check::get_field_info
    10.09%     +2.55%  [.] sinsp_filter_check::rawval_to_string
     5.49%     +2.32%  [.] sinsp_filter_check::get_transformed_field_info
    11.64%     -0.40%  [.] sinsp_filter_check_thread::extract_single
     6.25%     -0.40%  [.] rawstring_check::extract_single
     5.96%     -0.26%  [.] sinsp_filter_check_container::extract_single
     5.05%     +0.13%  [.] libsinsp::runc::match_container_id
     5.11%     -0.11%  [.] 0x00000000000a7cf0

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (686dfc0) to head (c47ab79).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2002   +/-   ##
=======================================
  Coverage   74.08%   74.08%           
=======================================
  Files         253      253           
  Lines       30766    30766           
  Branches     5386     5414   +28     
=======================================
  Hits        22792    22792           
- Misses       7946     7974   +28     
+ Partials       28        0   -28     
Flag Coverage Δ
libsinsp 74.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

@poiana
Copy link
Contributor

poiana commented Aug 12, 2024

LGTM label has been added.

Git tree hash: c2e5ec401700ec71fc6fbbe74515f55d329d3eb4

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 874e573 into falcosecurity:master Aug 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants