-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(libscap): fix scap_kmod build with HANDLE() macro #2010
Conversation
Signed-off-by: Luca Guerra <[email protected]>
Please double check driver/API_VERSION file. See versioning. /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you!
LGTM label has been added. Git tree hash: 55e076685c9b31d4a67870e3282049cf805d9282
|
Perf diff from master - unit tests
Perf diff from master - scap file
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 253 253
Lines 30805 30805
Branches 5404 5396 -8
=======================================
Hits 22835 22835
+ Misses 7951 7942 -9
- Partials 19 28 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, LucaGuerra, Molter73 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libscap
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Fix build error
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: