-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(semgrep): update semgrep docker image #2048
ci(semgrep): update semgrep docker image #2048
Conversation
Welcome @francesco-furlan! It looks like this is your first PR to falcosecurity/libs 🎉 |
Hi @francesco-furlan thank you for this! could you add the DCO to your commit as explained here https://github.com/falcosecurity/libs/blob/master/Contributing.md#add-dco-signed-off-to-your-commits- ? |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2048 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 254 254
Lines 31213 31213
Branches 5429 5422 -7
=======================================
Hits 23130 23130
- Misses 8060 8073 +13
+ Partials 23 10 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Francesco Furlan <[email protected]>
8040895
to
56cd7fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 58b4b2e4d5c3f234fb69eca1278b5130bf895bc2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, francesco-furlan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Semgrep has updated their official docker image to
semgrep/semgrep
Does this PR introduce a user-facing change?: