-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(driver): update exit events PPME_SYSCALL_WRITE_X
and PPME_SYSCALL_PWRITE_X
with enter params
#2187
base: master
Are you sure you want to change the base?
Conversation
623f01e
to
9a0e681
Compare
9a0e681
to
71b0419
Compare
@@ -1 +1 @@ | |||
3.0.0 | |||
4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same reason of #2176
// WRITE | ||
//////////////////////////// | ||
|
||
TEST_F(scap_file_test, write_x_check_final_converted_event) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably from now on it will be enough one test per event, it seems a little bit redundant to check every time if we receive the enter/exit events
71b0419
to
2aba429
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
==========================================
+ Coverage 75.38% 75.43% +0.04%
==========================================
Files 264 266 +2
Lines 34014 34093 +79
Branches 5805 5805
==========================================
+ Hits 25642 25717 +75
- Misses 8372 8376 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2aba429
to
9ec4889
Compare
PPME_SYSCALL_WRITE_X
and PPME_SYSCALL_PWRITE_X
with enter paramsPPME_SYSCALL_WRITE_X
and PPME_SYSCALL_PWRITE_X
with enter params
This needs #2202 |
9ec4889
to
0a3ff98
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
0a3ff98
to
ffd8678
Compare
PPME_SYSCALL_WRITE_X
and PPME_SYSCALL_PWRITE_X
with enter paramsPPME_SYSCALL_WRITE_X
and PPME_SYSCALL_PWRITE_X
with enter params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: d2563eeb0a9f2401dac00ba2c0041ef632b8aa55
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-major
What this PR does / why we need it:
This PR is part of #2068.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: