-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some issues with Clang 18 #2201
fix: some issues with Clang 18 #2201
Conversation
Signed-off-by: Federico Aponte <[email protected]>
LGTM label has been added. Git tree hash: 85d518fc472139405d73fe5a0015e8e1d122139c
|
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 261 261
Lines 33878 33878
Branches 5801 5801
=======================================
Hits 25475 25475
Misses 8403 8403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, federico-sysdig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Fix a few warnings and errors that came up during a build with Clang 18.
In addition, I've been working with a simplified version of
CMakePresets.json
where parameters common to several presets are factored out in a base preset. I took the liberty of adding these minor changes here.Which issue(s) this PR fixes:
Compilation errors and warnings with recent compilers.
Fixes #
n/a
Does this PR introduce a user-facing change?:
No