Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(driver): update exit events PPME_SOCKET_BIND_X with enter params #2205

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Dec 17, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-gvisor

/area libscap

/area libsinsp

/area tests

Does this PR require a change in the driver versions?

/version driver-API-version-minor

What this PR does / why we need it:

This PR is part of #2068.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Dec 17, 2024

Perf diff from master - unit tests

     9.39%     +1.46%  [.] sinsp::next
    10.61%     -1.31%  [.] sinsp_parser::reset
     3.14%     +0.62%  [.] sinsp_thread_manager::find_thread
     3.54%     -0.56%  [.] sinsp_parser::process_event
     3.09%     -0.44%  [.] sinsp_thread_manager::get_thread_ref
     0.91%     +0.40%  [.] sinsp_evt::get_ts
     7.57%     +0.36%  [.] sinsp_evt::get_type
     2.07%     -0.35%  [.] scap_event_decode_params
     0.98%     -0.35%  [.] sinsp_evt::get_direction
     1.53%     -0.35%  [.] sinsp::fetch_next_event

Heap diff from master - unit tests

peak heap memory consumption: -114B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -114B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0027         -0.0027           148           148           148           148
BM_sinsp_split_median                                          -0.0024         -0.0024           148           148           148           148
BM_sinsp_split_stddev                                          +1.7477         +1.7510             1             1             1             1
BM_sinsp_split_cv                                              +1.7552         +1.7585             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0005         +0.0005            56            56            56            56
BM_sinsp_concatenate_paths_relative_path_median                +0.0004         +0.0004            56            56            56            56
BM_sinsp_concatenate_paths_relative_path_stddev                +0.3151         +0.3164             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.3145         +0.3158             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0035         -0.0035            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0005         -0.0005            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8205         -0.8207             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8199         -0.8201             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0044         -0.0044            55            55            55            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.0047         -0.0047            55            55            55            55
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.2815         +1.2808             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.2917         +1.2910             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0042         -0.0042           384           382           384           382
BM_sinsp_split_container_image_median                          -0.0068         -0.0068           385           382           384           382
BM_sinsp_split_container_image_stddev                          +0.2412         +0.2392             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.2464         +0.2444             0             0             0             0

@ekoops ekoops force-pushed the ekoops/convert-bind branch from 4cb1374 to eedda2e Compare December 17, 2024 15:40
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work just some minor comments

@Andreagit97 Andreagit97 added this to the 0.20.0 milestone Dec 17, 2024
@ekoops ekoops force-pushed the ekoops/convert-bind branch from eedda2e to 2018698 Compare December 17, 2024 16:17
Andreagit97
Andreagit97 previously approved these changes Dec 17, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 17, 2024

LGTM label has been added.

Git tree hash: ece5eff4bec59598b9c49edbf42cb096ca0eedb6

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (9ee57c8) to head (71124d3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files         264      264           
  Lines       34014    34014           
  Branches     5805     5805           
=======================================
  Hits        25642    25642           
  Misses       8372     8372           
Flag Coverage Δ
libsinsp 75.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andreagit97 Andreagit97 self-requested a review December 17, 2024 16:45
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

LGTM label has been added.

Git tree hash: a3f812197ae01c243ddb71c98cd81a7ce75c8e9c

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 199a439 into falcosecurity:master Dec 18, 2024
58 of 59 checks passed
@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ekoops ekoops deleted the ekoops/convert-bind branch December 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants