Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(driver): update exit events PPME_SOCKET_SOCKET_X with enter params #2206

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-gvisor

/area libscap

/area libsinsp

/area tests

Does this PR require a change in the driver versions?

/version driver-SCHEMA-version-major

What this PR does / why we need it:

This PR is part of #2068.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (9ee57c8) to head (63beb96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   75.38%   75.37%   -0.02%     
==========================================
  Files         264      264              
  Lines       34014    33981      -33     
  Branches     5805     5803       -2     
==========================================
- Hits        25642    25613      -29     
+ Misses       8372     8368       -4     
Flag Coverage Δ
libsinsp 75.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -89,7 +89,7 @@
#define CAPSET_E_SIZE HEADER_LEN
#define CAPSET_X_SIZE HEADER_LEN + sizeof(int64_t) + sizeof(uint64_t) * 3 + PARAM_LEN * 4
#define SOCKET_E_SIZE HEADER_LEN + sizeof(uint32_t) * 3 + PARAM_LEN * 3
#define SOCKET_X_SIZE HEADER_LEN + sizeof(int64_t) + PARAM_LEN
#define SOCKET_X_SIZE HEADER_LEN + sizeof(int64_t) + sizeof(uint32_t) * 3 + PARAM_LEN * 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still looking for a way to automatically declare these ones 🤣 perhaps some constexpr magic?

FedeDP
FedeDP previously approved these changes Dec 17, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 17, 2024

LGTM label has been added.

Git tree hash: 3b4dac7335c93921a803038038d4db051a8e8844

@Andreagit97 Andreagit97 changed the title new(driver): update exit events PPME_SOCKET_SOCKET_X with enter params new(driver): update exit events PPME_SOCKET_SOCKET_X with enter params Dec 17, 2024
@poiana poiana removed the lgtm label Dec 18, 2024
@poiana poiana requested a review from FedeDP December 18, 2024 10:00
FedeDP
FedeDP previously approved these changes Dec 18, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 18, 2024
@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

LGTM label has been added.

Git tree hash: 7fb0eb1e129e9f087beb614a564c95a4fc967239

Copy link

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@Andreagit97 Andreagit97 force-pushed the convert_socket branch 3 times, most recently from acd68e5 to de17e13 Compare December 18, 2024 11:58
Signed-off-by: Andrea Terzolo <[email protected]>
Copy link

Perf diff from master - unit tests

     0.92%     +1.64%  [.] sinsp_parser::event_cleanup
    11.01%     -1.10%  [.] sinsp_parser::reset
     0.31%     +0.88%  [.] sinsp_evt::is_filtered_out
     5.18%     +0.83%  [.] next_event_from_file
     3.18%     -0.76%  [.] sinsp_parser::process_event
    11.88%     +0.42%  [.] sinsp::next
     0.85%     -0.40%  [.] scap_event_has_large_payload
     1.92%     +0.35%  [.] is_conversion_needed
     3.35%     +0.32%  [.] sinsp_evt::load_params
     3.33%     -0.30%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

peak heap memory consumption: -527B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -118B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0283         +0.0284           149           153           149           153
BM_sinsp_split_median                                          +0.0242         +0.0243           149           153           149           153
BM_sinsp_split_stddev                                          -0.0474         -0.0474             2             1             2             1
BM_sinsp_split_cv                                              -0.0736         -0.0737             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0813         +0.0814            56            61            56            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0853         +0.0854            56            61            56            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8081         -0.8089             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8226         -0.8233             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0117         -0.0116            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0136         -0.0135            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.9031         +0.9054             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.9257         +0.9278             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1190         +0.1191            56            63            56            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.0994         +0.0995            57            62            57            62
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.0127         +0.0134             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.0949         -0.0944             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0149         -0.0148           395           389           395           389
BM_sinsp_split_container_image_median                          -0.0171         -0.0170           396           389           396           389
BM_sinsp_split_container_image_stddev                          +0.2228         +0.2219             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.2413         +0.2403             0             0             0             0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 18, 2024
@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

LGTM label has been added.

Git tree hash: 756534102c210cd5c58f3d8afd385a9eef9ccdab

@poiana
Copy link
Contributor

poiana commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b15675b into falcosecurity:master Dec 18, 2024
54 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants