-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(driver): update exit events PPME_SOCKET_SOCKET_X
with enter params
#2206
Conversation
e9f5344
to
63beb96
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
- Coverage 75.38% 75.37% -0.02%
==========================================
Files 264 264
Lines 34014 33981 -33
Branches 5805 5803 -2
==========================================
- Hits 25642 25613 -29
+ Misses 8372 8368 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -89,7 +89,7 @@ | |||
#define CAPSET_E_SIZE HEADER_LEN | |||
#define CAPSET_X_SIZE HEADER_LEN + sizeof(int64_t) + sizeof(uint64_t) * 3 + PARAM_LEN * 4 | |||
#define SOCKET_E_SIZE HEADER_LEN + sizeof(uint32_t) * 3 + PARAM_LEN * 3 | |||
#define SOCKET_X_SIZE HEADER_LEN + sizeof(int64_t) + PARAM_LEN | |||
#define SOCKET_X_SIZE HEADER_LEN + sizeof(int64_t) + sizeof(uint32_t) * 3 + PARAM_LEN * 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still looking for a way to automatically declare these ones 🤣 perhaps some constexpr
magic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 3b4dac7335c93921a803038038d4db051a8e8844
|
PPME_SOCKET_SOCKET_X
with enter params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 7fb0eb1e129e9f087beb614a564c95a4fc967239
|
ad123bc
to
a1c3d16
Compare
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
acd68e5
to
de17e13
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
de17e13
to
816967b
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 756534102c210cd5c58f3d8afd385a9eef9ccdab
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libscap
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
/version driver-SCHEMA-version-major
What this PR does / why we need it:
This PR is part of #2068.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: